Skip to content

Batched hierarchical requests#490

Merged
mallport merged 10 commits intomainfrom
draft-batched-hierarchical
Mar 5, 2026
Merged

Batched hierarchical requests#490
mallport merged 10 commits intomainfrom
draft-batched-hierarchical

Conversation

@mallport
Copy link
Contributor

@mallport mallport commented Feb 17, 2026

This change is Reviewable

@mallport mallport marked this pull request as ready for review March 4, 2026 13:31
Copy link
Contributor

@skykanin skykanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skykanin reviewed 2 files and all commit messages, and made 3 comments.
Reviewable status: 2 of 9 files reviewed, 3 unresolved discussions (waiting on mallport).


src/dapla_pseudo/utils.py line 283 at r1 (raw file):

    Two paths share a request only when all of these match:
    - normalized request name (array indices removed)

This shouls be path


src/dapla_pseudo/utils.py line 304 at r1 (raw file):

    for _, fields in grouped.items():
        representative = fields[0]
        request_name = _remove_array_indices(representative.path)

This should be request_path


tests/v1/integration/test_hierarchical.py line 163 at r1 (raw file):

@pytest.mark.usefixtures("setup")
@integration_test()
def test_hierarchical_request_batching_daead(

Add tests for depseudo and repseudo as well

@mallport mallport merged commit 584570c into main Mar 5, 2026
18 of 19 checks passed
@mallport mallport deleted the draft-batched-hierarchical branch March 5, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants