Conversation
skykanin
requested changes
Mar 4, 2026
Contributor
skykanin
left a comment
There was a problem hiding this comment.
@skykanin reviewed 2 files and all commit messages, and made 3 comments.
Reviewable status: 2 of 9 files reviewed, 3 unresolved discussions (waiting on mallport).
src/dapla_pseudo/utils.py line 283 at r1 (raw file):
Two paths share a request only when all of these match: - normalized request name (array indices removed)
This shouls be path
src/dapla_pseudo/utils.py line 304 at r1 (raw file):
for _, fields in grouped.items(): representative = fields[0] request_name = _remove_array_indices(representative.path)
This should be request_path
tests/v1/integration/test_hierarchical.py line 163 at r1 (raw file):
@pytest.mark.usefixtures("setup") @integration_test() def test_hierarchical_request_batching_daead(
Add tests for depseudo and repseudo as well
skykanin
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is